Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/24285 )
Change subject: KUDU-3732 Get consensus state from CatalogManager in auto-rebalancer ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/24285/4/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/24285/4/src/kudu/master/auto_rebalancer.cc@504 PS4, Line 504: { : CatalogManager::ScopedLeaderSharedLock l(catalog_manager_); : RETURN_NOT_OK(l.first_failed_status()); : RETURN_NOT_OK(catalog_manager_->GetTabletConsensusState(tablet_id, &pre_cstate)); : } : const int64_t pre_opid_index = pre_cstate.committed_config().opid_index(); : : string leader_uuid; : HostPort leader_hp; : RETURN_NOT_OK(GetTabletLeader(tablet_id, &leader_uuid, &leader_hp)); > GetTabletConsensusState (line 504-508) and GetTabletLeader (line 513) each Done http://gerrit.cloudera.org:8080/#/c/24285/4/src/kudu/master/auto_rebalancer.cc@549 PS4, Line 549: n pre_opid_index. > nit: should this be pre_opid_index + N (N > 1) if there are non-config entr Done http://gerrit.cloudera.org:8080/#/c/24285/4/src/kudu/master/auto_rebalancer.cc@931 PS4, Line 931: // populated in ExecuteMoves immediately after BulkChangeConfig succeeds, > If the DCHECK above is correct, the Done -- To view, visit http://gerrit.cloudera.org:8080/24285 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba021539fbfaca5905fbbf4abbb6e2a61db1f7dc Gerrit-Change-Number: 24285 Gerrit-PatchSet: 6 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Thu, 28 May 2026 14:41:21 +0000 Gerrit-HasComments: Yes
