Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24285 )
Change subject: KUDU-3732 Get consensus state from CatalogManager in auto-rebalancer ...................................................................... Patch Set 6: Code-Review+1 (2 comments) Overall LGTM, a few questions. Thanks for revving this patch! http://gerrit.cloudera.org:8080/#/c/24285/6/src/kudu/master/auto_rebalancer-test.cc File src/kudu/master/auto_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/24285/6/src/kudu/master/auto_rebalancer-test.cc@1452 PS6, Line 1452: move.ts_uuid_to = "fake-destination-uuid"; Could setting fake destination UUID prevent the move to complete regardless of the condition on the opid index? If it's still legit and works as expected, please add a comment why fake destination UUID wouldn't stop the move to complete. http://gerrit.cloudera.org:8080/#/c/24285/6/src/kudu/master/auto_rebalancer-test.cc@1554 PS6, Line 1554: rebalance::Rebalancer::ReplicaMove move; : move.tablet_uuid = tablet_id; : move.ts_uuid_from = src_ts_uuid; : move.ts_uuid_to = dst_ts_uuid; The config_opid_idx field isn't set. Is it intentional? -- To view, visit http://gerrit.cloudera.org:8080/24285 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba021539fbfaca5905fbbf4abbb6e2a61db1f7dc Gerrit-Change-Number: 24285 Gerrit-PatchSet: 6 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 29 May 2026 01:56:50 +0000 Gerrit-HasComments: Yes
