Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24383 )
Change subject: KUDU-3781: add TLS transport support for HMS client ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/24383/2/src/kudu/thrift/client.cc File src/kudu/thrift/client.cc: http://gerrit.cloudera.org:8080/#/c/24383/2/src/kudu/thrift/client.cc@80 PS2, Line 80: TSSLSocketFactory::setManualOpenSSLInitialization(true); > Should this be hoisted into the existing `std::call_once` block a few lines Yes, we can do that. The call is setting a boolean static variable, but it wouldn't hurt if calling it only once even if this isn't on the hot path. http://gerrit.cloudera.org:8080/#/c/24383/2/src/kudu/thrift/client.cc@86 PS2, Line 86: sf.loadTrustedCertificates(options.tls_trusted_ca_cert_file.c_str()); > Is it possible, that a bad path would trigger the throw in loadTrustedCerti That's a very good point. I need to add more negative-style test scenarios into hms_client-test to test not only happy paths, but when something is missing or contains something different than expected. -- To view, visit http://gerrit.cloudera.org:8080/24383 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9658323ed9aebdfdf8e6847c9c3129f5c8517c65 Gerrit-Change-Number: 24383 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 01 Jun 2026 14:46:42 +0000 Gerrit-HasComments: Yes
