Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/24383 )
Change subject: KUDU-3781: add TLS transport support for HMS client ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/24383/3/src/kudu/hms/hms_client-test.cc File src/kudu/hms/hms_client-test.cc: http://gerrit.cloudera.org:8080/#/c/24383/3/src/kudu/hms/hms_client-test.cc@699 PS3, Line 699: MiniHms hms; : hms.EnableTls(true); : : // Set the `KUDU_HMS_SYNC_ENABLED` environment variable in the : // HMS environment to manually enable HMS synchronization checks. : // This means we don't need to stand up a Kudu Cluster for this test. : hms.AddEnvVar("KUDU_HMS_SYNC_ENABLED", "1"); : ASSERT_OK(hms.Start()); nit: Can the repetition in these four lines across the tests be avoided with a helper function? -- To view, visit http://gerrit.cloudera.org:8080/24383 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9658323ed9aebdfdf8e6847c9c3129f5c8517c65 Gerrit-Change-Number: 24383 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 02 Jun 2026 23:39:40 +0000 Gerrit-HasComments: Yes
