Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/24383 )
Change subject: KUDU-3781: add TLS transport support for HMS client ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/24383/3/src/kudu/hms/hms_catalog.cc File src/kudu/hms/hms_catalog.cc: http://gerrit.cloudera.org:8080/#/c/24383/3/src/kudu/hms/hms_catalog.cc@76 PS3, Line 76: DEFINE_string(hive_metastore_tls_trusted_ca_cert_file, "", We already have a -trusted_certificate_file flag. Wouldn't it make more sense to rely on that one as well? http://gerrit.cloudera.org:8080/#/c/24383/3/src/kudu/hms/hms_client-test.cc File src/kudu/hms/hms_client-test.cc: http://gerrit.cloudera.org:8080/#/c/24383/3/src/kudu/hms/hms_client-test.cc@229 PS3, Line 229: ASSERT_STR_CONTAINS(CreateTable(client.get(), database_name, table_name, "", cluster_id).ToString(), nit: long line http://gerrit.cloudera.org:8080/#/c/24383/3/src/kudu/hms/hms_client.cc File src/kudu/hms/hms_client.cc: http://gerrit.cloudera.org:8080/#/c/24383/3/src/kudu/hms/hms_client.cc@201 PS3, Line 201: //DCHECK_NE(nullptr, (*client)->get()); nit: should this be removed? http://gerrit.cloudera.org:8080/#/c/24383/3/src/kudu/integration-tests/master_hms-itest.cc File src/kudu/integration-tests/master_hms-itest.cc: http://gerrit.cloudera.org:8080/#/c/24383/3/src/kudu/integration-tests/master_hms-itest.cc@104 PS3, Line 104: emf.emplace_back("--hive_metastore_tls_enabled"); what happens if TLS is enabled on Kudu side, but not on HMS side? -- To view, visit http://gerrit.cloudera.org:8080/24383 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9658323ed9aebdfdf8e6847c9c3129f5c8517c65 Gerrit-Change-Number: 24383 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 02 Jun 2026 17:09:58 +0000 Gerrit-HasComments: Yes
