Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24435 )
Change subject: KUDU-3780: introduce KUDU_CLIENT_ONLY build option ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/24435/4/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/24435/4/CMakeLists.txt@54 PS4, Line 54: if(KUDU_CLIENT_ONLY) > It'd be nice if this also implied "KUDU_CLIENT_INSTALL=OFF KUDU_MASTER_INST It's a good idea. I missed addressing this comment in PS5, will address in PS6. http://gerrit.cloudera.org:8080/#/c/24435/4/CMakeLists.txt@198 PS4, Line 198: COMMAND ${THIRDPARTY_DIR}/build-if-necessary.sh ${TP_ARGS} > This should take into account KUDU_CLIENT_ONLY. Indeed; this is what was missing, so you saw it was (re)building LLVM when the 3rd-party was originally built with 'client_only'. Fixed. -- To view, visit http://gerrit.cloudera.org:8080/24435 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc8b021e03808a3ca8da6cfff617bc913772f271 Gerrit-Change-Number: 24435 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 12 Jun 2026 22:13:45 +0000 Gerrit-HasComments: Yes
