Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24435 )

Change subject: KUDU-3780: introduce KUDU_CLIENT_ONLY build option
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24435/4/CMakeLists.txt
File CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/24435/4/CMakeLists.txt@54
PS4, Line 54: if(KUDU_CLIENT_ONLY)
> It's a good idea.  I missed addressing this comment in PS5, will address in
As an afterthought, I realized that KUDU_MASTER_INSTALL and 
KUDU_TSERVER_INSTALL isn't applicable since neither of kudu-master or 
kudu-tservere binaries are built when running with -DKUDU_CLIENT_ONLY=1 cmake 
flag.

KUDU_CLIENT_INSTALL looks related, but isn't effective/applicable either: since 
running with explicit targets 'kudu_client' and 'kudu_client_exported', the 
built library isn't going to be installed anyway.

I hope this makes sense to you.



--
To view, visit http://gerrit.cloudera.org:8080/24435
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc8b021e03808a3ca8da6cfff617bc913772f271
Gerrit-Change-Number: 24435
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Mon, 15 Jun 2026 14:04:38 +0000
Gerrit-HasComments: Yes

Reply via email to