Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24435 )
Change subject: KUDU-3780: introduce KUDU_CLIENT_ONLY build option ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/24435/4/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/24435/4/CMakeLists.txt@54 PS4, Line 54: if(KUDU_CLIENT_ONLY) > As an afterthought, I realized that KUDU_MASTER_INSTALL and KUDU_TSERVER_IN One more note to clarify on those KUDU_XXX_INSTALL flags for cmake: KUDU_CLIENT_INSTALL isn't about Kudu C++ client, that's about installing the kudu CLI tool (seems to be a misnomer IMO). So, KUDU_CLIENT_INSTALL isn't applicable since the kudu CLI tool isn't built at all when specifying KUDU_CLIENT_ONLY. In other words, KUDU_CLIENT_INSTALL is irrelevant here, similar to KUDU_MASTER_INSTALL and KUDU_TSERVER_INSTALL. When building with -DKUDU_CLIENT_ONLY=1, no need to add either of those KUDU_XXX_INSTALL flags; and even if they are specified, they don't change anything. http://gerrit.cloudera.org:8080/#/c/24435/6/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/24435/6/CMakeLists.txt@60 PS6, Line 60: insn't > nit: isn't Done http://gerrit.cloudera.org:8080/#/c/24435/6/docs/installation.adoc File docs/installation.adoc: http://gerrit.cloudera.org:8080/#/c/24435/6/docs/installation.adoc@725 PS6, Line 725: Bulding > nit: Building Done -- To view, visit http://gerrit.cloudera.org:8080/24435 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc8b021e03808a3ca8da6cfff617bc913772f271 Gerrit-Change-Number: 24435 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 15 Jun 2026 16:20:04 +0000 Gerrit-HasComments: Yes
