Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24475 )
Change subject: KUDU-3785: Fix CLI flag validator failure ...................................................................... Patch Set 3: Code-Review+1 (5 comments) LGTM overall; a few nits. http://gerrit.cloudera.org:8080/#/c/24475/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24475/3//COMMIT_MSG@20 PS3, Line 20: and triggers server-side validators nit: those aren't server-side, but rather global validators http://gerrit.cloudera.org:8080/#/c/24475/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/24475/3/src/kudu/tools/kudu-tool-test.cc@11136 PS3, Line 11136: without relying on global flag inflation. Maybe, drop this part since it's no longer relevant: it's now confusing on top of questionable word choice. http://gerrit.cloudera.org:8080/#/c/24475/3/src/kudu/tools/kudu-tool-test.cc@11141 PS3, Line 11141: ASSERT_OK(BuildMessenger("test", &messenger)); Does it make sense to add an assertion on --rpc_max_message_size keeping its default setting at this point? It could help in troubleshooting if this implicit invariant is broken for some reason. http://gerrit.cloudera.org:8080/#/c/24475/3/src/kudu/tools/kudu-tool-test.cc@11142 PS3, Line 11142: ASSERT_GT(messenger->rpc_max_message_size(), FLAGS_rpc_max_message_size); nit: maybe, add a comment that this assumes the amount of available memory on the machine running the test is higher than the default setting of the --rpc_max_message_size flag. This could help in troubleshooting if this assertion ever triggers due to modifications on the default setting for rpc_max_message_size. http://gerrit.cloudera.org:8080/#/c/24475/3/src/kudu/tools/kudu-tool-test.cc@11153 PS3, Line 11153: } I'd think of reverting the customization of the --rpc_max_message_size setting to avoid surprises, unless it's already taken care automatically. -- To view, visit http://gerrit.cloudera.org:8080/24475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd24ec605bd14ce90ed8a5705230ff96d77d0d64 Gerrit-Change-Number: 24475 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 18 Jun 2026 20:30:54 +0000 Gerrit-HasComments: Yes
