Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24475 )
Change subject: KUDU-3785: Fix CLI flag validator failure ...................................................................... Patch Set 4: Code-Review+1 (1 comment) LGTM! Just one nit to cover all bases in the test. http://gerrit.cloudera.org:8080/#/c/24475/4/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/24475/4/src/kudu/tools/kudu-tool-test.cc@11160 PS4, Line 11160: Edge case: nit: While you are at it, maybe add one more test where FLAGS_rpc_max_message_size is set to default (i.e. 50MB) followed by BuildMessenger() call and ASSERT to verify the actual size set in messenger object. -- To view, visit http://gerrit.cloudera.org:8080/24475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd24ec605bd14ce90ed8a5705230ff96d77d0d64 Gerrit-Change-Number: 24475 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 22 Jun 2026 15:03:47 +0000 Gerrit-HasComments: Yes
