Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24475 )
Change subject: KUDU-3785: Fix CLI flag validator failure ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/24475/4/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/24475/4/src/kudu/tools/kudu-tool-test.cc@11160 PS4, Line 11160: Edge case: > Not sure if I understand: the scenario you described matches what the lates I see my earlier statement may seem confusing. Basically, I was suggesting to add another test case where flag (FLAGS_rpc_max_message_size) is programmatically set to default value (and not using SetCommandLineOption), followed by regular init and verification checks. Something like this: ++ FLAGS_rpc_max_message_size = 52428800; std::shared_ptr<rpc::Messenger> messenger; ASSERT_OK(BuildMessenger("test", &messenger)); ASSERT_EQ(52428800, messenger->rpc_max_message_size()); messenger->Shutdown(); ++ I understand that this kind of flag assignment happens only via code but worth adding such scenario in the test if possible. -- To view, visit http://gerrit.cloudera.org:8080/24475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd24ec605bd14ce90ed8a5705230ff96d77d0d64 Gerrit-Change-Number: 24475 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 22 Jun 2026 17:26:01 +0000 Gerrit-HasComments: Yes
