Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24581 )
Change subject: WIP [thirdparty] update boost up 1.91.0 ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/24581/2/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/24581/2/thirdparty/build-definitions.sh@968 PS2, Line 968: 1.19.0 nit: 1.91.0 http://gerrit.cloudera.org:8080/#/c/24581/2/thirdparty/build-definitions.sh@971 PS2, Line 971: CFLAGS="$BOOST_CFLAGS" \ : CXXFLAGS="$BOOST_CXXFLAGS" \ : LDFLAGS="$BOOST_LDFLAGS" \ Can these be cmake -D flags (e.g. -DCMAKE_CXX_FLAGS) instead of environment variables, to avoid any scoping issues? http://gerrit.cloudera.org:8080/#/c/24581/2/thirdparty/download-thirdparty.sh File thirdparty/download-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/24581/2/thirdparty/download-thirdparty.sh@389 PS2, Line 389: "patch -p0 < $TP_DIR/patches/boost-bootstrap.patch" Is this still applicable? -- To view, visit http://gerrit.cloudera.org:8080/24581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c9c2e9260b892c721ec2ba887c61b8aeef35888 Gerrit-Change-Number: 24581 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 14 Jul 2026 14:15:56 +0000 Gerrit-HasComments: Yes
