Abhishek Chennaka has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24581 )

Change subject: WIP [thirdparty] update boost up 1.91.0
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24581/3/thirdparty/vars.sh
File thirdparty/vars.sh:

PS3:
What are your thoughts on using the cmake compliant sources which they just 
started shipping (maybe for the future non-beta versions):

https://github.com/boostorg/boost/releases/download/boost-1.92.0.beta1/boost-1.92.0.beta1-cmake.7z


http://gerrit.cloudera.org:8080/#/c/24581/3/thirdparty/vars.sh@188
PS3, Line 188: git clone --recursive https://github.com/boostorg/boost.git
nit: Why not do something like:
git clone --branch boost-1.91.0 --depth 1 https://github.com/boostorg/boost.git
And then use the same --depth 1 argument for `git submodule..` below



--
To view, visit http://gerrit.cloudera.org:8080/24581
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9c2e9260b892c721ec2ba887c61b8aeef35888
Gerrit-Change-Number: 24581
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 14 Jul 2026 23:51:04 +0000
Gerrit-HasComments: Yes

Reply via email to