Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/24594 )
Change subject: auto_leader_rebalancer: best-effort leader step-down ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/24594/2/src/kudu/master/auto_leader_rebalancer.cc File src/kudu/master/auto_leader_rebalancer.cc: PS2: > How complicated would writing a test to this new behavior is? If it's not t I have added a test + a flag to help exercise that path. http://gerrit.cloudera.org:8080/#/c/24594/2/src/kudu/master/auto_leader_rebalancer.cc@450 PS2, Line 450: // tables; the next round re > Do we still need this check? Yes, I think we still want it: response.has_error() is the app-level error, which is separate from the RPC status I now handle above. It was underused here though, it only gated the log. I've made this path match the global one below: warn on a response error and only count actual successes. -- To view, visit http://gerrit.cloudera.org:8080/24594 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fb2c7a8bf750520d34d9aba62274dbe7433d80d Gerrit-Change-Number: 24594 Gerrit-PatchSet: 3 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Thu, 23 Jul 2026 18:05:19 +0000 Gerrit-HasComments: Yes
