Zoltan Chovan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24594 )

Change subject: auto_leader_rebalancer: best-effort leader step-down
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24594/4/src/kudu/master/auto_leader_rebalancer.cc
File src/kudu/master/auto_leader_rebalancer.cc:

http://gerrit.cloudera.org:8080/#/c/24594/4/src/kudu/master/auto_leader_rebalancer.cc@99
PS4, Line 99: TEST_leader_rebalancer_fail_step_down
I don't think we use TEST_ to mark flags for test use only. The naming is 
usually <flag_name>_for_test[ing] or lowercase test_<flag_name>



--
To view, visit http://gerrit.cloudera.org:8080/24594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fb2c7a8bf750520d34d9aba62274dbe7433d80d
Gerrit-Change-Number: 24594
Gerrit-PatchSet: 4
Gerrit-Owner: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Comment-Date: Mon, 27 Jul 2026 10:40:45 +0000
Gerrit-HasComments: Yes

Reply via email to