Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24650 )
Change subject: KUDU-3362: expose per-tablet stats via table statistics ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/24650/1/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/24650/1/src/kudu/tools/tool_action_table.cc@1619 PS1, Line 1619: LeaderMasterProxy proxy; q: When --show_tablets is set we issue a second GetTableStatistics RPC (the first was via client->GetTableStatistics at line 1609). The second response already carries the table-level on_disk_size/live_row_count, so the first call is redundant in this path. Not worth adding a client-API surface for, but did you consider only making the direct proxy call when --show_tablets is set, and rendering the table-level line from that same response to avoid the double round-trip? http://gerrit.cloudera.org:8080/#/c/24650/1/src/kudu/tools/tool_action_table.cc@1633 PS1, Line 1633: DataTable data_table({ "tablet_id", "on_disk_size", "live_row_count" }); nit: Consider printing a short section header (e.g. "TABLETS") before this DataTable, so the per-tablet block is visually distinct from the table-level statistics above it. -- To view, visit http://gerrit.cloudera.org:8080/24650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7889669181633a762c614afe96a9ea0827ed7f1 Gerrit-Change-Number: 24650 Gerrit-PatchSet: 1 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 31 Jul 2026 12:12:13 +0000 Gerrit-HasComments: Yes
