Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24650 )
Change subject: KUDU-3362: expose per-tablet stats via table statistics ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Thank you for working on this improvement! http://gerrit.cloudera.org:8080/#/c/24650/2/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/24650/2/src/kudu/tools/tool_action_table.cc@1640 PS2, Line 1640: resp.has_on_disk_size() ? std::to_string(resp.on_disk_size()) : "N/A", nit: The table-level on_disk_size here is printed as a raw byte count (via std::to_string), while the per-tablet on_disk_size at line 1651 uses HumanReadableNumBytes::ToString(). This means the same table might show "on disk size: 3145728" at the top and "3.0M" in the tablet row below. The raw format matches the existing KuduTableStatistics::ToString() output (backward-compatible), so I can see why it was kept. Could you file a ticket about using human readable consistently in both places - i think this is a fine newbie ticket - ? (I dont want to hold up this patch as i think its already in good shape) -- To view, visit http://gerrit.cloudera.org:8080/24650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7889669181633a762c614afe96a9ea0827ed7f1 Gerrit-Change-Number: 24650 Gerrit-PatchSet: 2 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Comment-Date: Thu, 06 Aug 2026 13:35:32 +0000 Gerrit-HasComments: Yes
