Yan-Daojiang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24650 )
Change subject: KUDU-3362: expose per-tablet stats via table statistics ...................................................................... Patch Set 2: (2 comments) Thanks for the review, Done! http://gerrit.cloudera.org:8080/#/c/24650/1/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/24650/1/src/kudu/tools/tool_action_table.cc@1619 PS1, Line 1619: // Otherwise a single RPC returns both the table-level and per-tablet > q: When --show_tablets is set we issue a second GetTableStatistics RPC (the I've reworked the function so that the client API is used only when tablet stats aren't requested; when --show_tablets is set, we issue just the single proxy RPC and render the table-level line from that same response. No new client-API surface added. Done. http://gerrit.cloudera.org:8080/#/c/24650/1/src/kudu/tools/tool_action_table.cc@1633 PS1, Line 1633: } > nit: Consider printing a short section header (e.g. "TABLETS") before this Done -- To view, visit http://gerrit.cloudera.org:8080/24650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7889669181633a762c614afe96a9ea0827ed7f1 Gerrit-Change-Number: 24650 Gerrit-PatchSet: 2 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Comment-Date: Thu, 06 Aug 2026 11:15:12 +0000 Gerrit-HasComments: Yes
