Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24578 )
Change subject: Add diff-scan option to return unobservable rows ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/24578/6/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/24578/6/src/kudu/client/client-test.cc@9650 PS6, Line 9650: TestDiffScanReinsertReportedLive nit for here and elsewhere: there is no need to add 'Test' as the prefix for the name of the test scenario -- there is 'Test' in the name of the test itself, so full name of this scenario is now already ClientTest.TestDiffScanReinsertReportedLive while it could have been ClientTest.DiffScanReinsertReportedLive http://gerrit.cloudera.org:8080/#/c/24578/6/src/kudu/client/client-test.cc@9708 PS6, Line 9708: TestDiffScanReinsertViaUpsertThenDeleteReportedDeleted It seems this scenario consistently fails in every build configuration (DEBUG, RELEASE, ASAN, TSAN) in pre-commit tests: * http://dist-test.cloudera.org/job?job_id=jenkins-slave.1785785469.3057850 * http://dist-test.cloudera.org/job?job_id=jenkins-slave.1785785621.3978626 * http://dist-test.cloudera.org/job?job_id=jenkins-slave.1785785635.3071396 * http://dist-test.cloudera.org/job?job_id=jenkins-slave.1785785786.3988806 http://gerrit.cloudera.org:8080/#/c/24578/6/src/kudu/client/client-test.cc@9728 PS6, Line 9728: TestDiffScanIncludeUnobservableRows It seems this scenario consistently fails in every build configuration (DEBUG, RELEASE, ASAN, TSAN) in pre-commit tests: * http://dist-test.cloudera.org/job?job_id=jenkins-slave.1785785469.3057850 * http://dist-test.cloudera.org/job?job_id=jenkins-slave.1785785621.3978626 * http://dist-test.cloudera.org/job?job_id=jenkins-slave.1785785635.3071396 * http://dist-test.cloudera.org/job?job_id=jenkins-slave.1785785786.3988806 -- To view, visit http://gerrit.cloudera.org:8080/24578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d0727fb2b89c727c669ec218e3bb8594336359a Gerrit-Change-Number: 24578 Gerrit-PatchSet: 6 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 03 Aug 2026 21:00:12 +0000 Gerrit-HasComments: Yes
