Zoltan Martonka has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24578 )

Change subject: Add diff-scan option to return unobservable rows
......................................................................


Patch Set 7:

Is it really sufficient for "change-data-capture pipeline reconstructing 
row-level history "?

Suppose I have a tablet which is basically a map<string,int>, and I do the 
following:

upsert "a",5
<diff_start_time>
upsert "a",6
upsert "a",7
delete "a"
<diff_end_time>

Would the diff scan report values 6,7 or just the fact that "a" got deleted.

Is my understanding correct, that the commit is supposed to addresses the 
following issue:

Insert a row, then wait until it goes to 2nd storage. (First storage is Kudu). 
Then upsert and delete it within a short timeframe.

Basically from Kudu point of view.
insert "a",5  // Happened long time ago 
delete "a" // System sent this because it was moved to db_whatever.
<diff_start_time>
upsert "a",6
upsert "a",7
delete "a"
<diff_end_time>

In this case we only need the "deleted=true" info to remove the row from second 
layer, right?


If my understanding is correct, then please update the commit message to better 
mirror what this change enable, and what it does not (full cdc row-level 
history). And what is the problem that triggered this commit.

Also for a change touching such a core thing including a jira ticket into the 
commit message would be nice.


--
To view, visit http://gerrit.cloudera.org:8080/24578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d0727fb2b89c727c669ec218e3bb8594336359a
Gerrit-Change-Number: 24578
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Comment-Date: Thu, 13 Aug 2026 20:57:18 +0000
Gerrit-HasComments: No

Reply via email to