Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/24578 )
Change subject: Add diff-scan option to return unobservable rows ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/24578/7/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/24578/7/src/kudu/client/client.cc@1912 PS7, Line 1912: Status KuduScanner::SetDiffScan(uint64_t start_timestamp, uint64_t end_timestamp) { : if (data_->open_) { : return Status::IllegalState("Diff scan must be set before Open()"); : } : return data_->mutable_configuration()->SetDiffScan(start_timestamp, end_timestamp); : } nit: Could this just call the 3 param version with default visibility? -- To view, visit http://gerrit.cloudera.org:8080/24578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d0727fb2b89c727c669ec218e3bb8594336359a Gerrit-Change-Number: 24578 Gerrit-PatchSet: 7 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Thu, 13 Aug 2026 21:17:02 +0000 Gerrit-HasComments: Yes
