Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24615 )
Change subject: [tablet] Skip stable_sort for already sorted batch ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24615/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24615/2//COMMIT_MSG@18 PS2, Line 18: This patch tracks an 'is_sorted' flag while building 'keys_and_indexes' : in the loop that already scans every op, flipping it to false on the : first out-of-order pair. When the flag survives to the end of the loop, : the stable_sort is skipped entirely, improving performance by a slight : margin if not significant. I'm a bit skeptical since I'd expect that contemporary implementations of std::stable_sort() are designed to handle pre-sorted data efficiently, so this extra hustle wouldn't provide much benefit. I'd be great to have unit-level bench here: perf-loadgen is very noisy especially when running it for quite a long time in a shared environment or DEBUG builds. -- To view, visit http://gerrit.cloudera.org:8080/24615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28d3f5ebdf7e3f13f04ffe8d35417a98c370fcf7 Gerrit-Change-Number: 24615 Gerrit-PatchSet: 2 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Thu, 06 Aug 2026 06:46:00 +0000 Gerrit-HasComments: Yes
