Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24615 )
Change subject: [tablet] Skip stable_sort for already sorted batch ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/24615/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24615/2//COMMIT_MSG@31 PS2, Line 31: > If targeting a custom environment with a lot of rows per RPC batch, I'd cus Indeed! --buffer_size_bytes sounds better option here. I have updated the numbers with customized --buffer_size_bytes and default --buffer_flush_watermark_pct. Thanks! http://gerrit.cloudera.org:8080/#/c/24615/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24615/3//COMMIT_MSG@31 PS3, Line 31: --run_scan=false > nit: it seems I missed it in prior review pass, but this flag doesn't requi Done http://gerrit.cloudera.org:8080/#/c/24615/3/src/kudu/tablet/tablet-test.cc File src/kudu/tablet/tablet-test.cc: http://gerrit.cloudera.org:8080/#/c/24615/3/src/kudu/tablet/tablet-test.cc@1832 PS3, Line 1832: EXPECT_EQ(pre_sorted_before + 1, PreSortedCount()); : EXPECT_EQ(needed_sort_before, NeededSortCount()); > nit for here and elsewhere: any particular reason to use EXPECT_xxx instead LLM bloopers :) Converted to ASSERT_EQ wherever applicable. http://gerrit.cloudera.org:8080/#/c/24615/3/src/kudu/tablet/tablet_metrics.h File src/kudu/tablet/tablet_metrics.h: http://gerrit.cloudera.org:8080/#/c/24615/3/src/kudu/tablet/tablet_metrics.h@78 PS3, Line 78: // Fast-path / slow-path split for the sort-skip optimisation in : // Tablet::BulkCheckPresence. : scoped_refptr<Counter> bulk_check_batches_pre_sorted; : scoped_refptr<Counter> bulk_check_batches_needed_sort; > Reiterating on my question at https://gerrit.cloudera.org/#/c/24615/2/src/k We could use these metrics for workload characterization in terms of ordering in writes. For a OLAP bulk ingest, the batches are expected to be ordered and if the 'bulk_check_batches_pre_sorted' tells otherwise, it could prove to be a valuable information in debugging, at a negligible cost. -- To view, visit http://gerrit.cloudera.org:8080/24615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28d3f5ebdf7e3f13f04ffe8d35417a98c370fcf7 Gerrit-Change-Number: 24615 Gerrit-PatchSet: 3 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Wed, 02 Sep 2026 13:07:05 +0000 Gerrit-HasComments: Yes
