Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24615 )
Change subject: [tablet] Skip stable_sort for already sorted batch ...................................................................... Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/24615/3/src/kudu/tablet/tablet_metrics.h File src/kudu/tablet/tablet_metrics.h: http://gerrit.cloudera.org:8080/#/c/24615/3/src/kudu/tablet/tablet_metrics.h@78 PS3, Line 78: // Fast-path / slow-path split for the sort-skip optimisation in : // Tablet::BulkCheckPresence. : scoped_refptr<Counter> bulk_check_batches_pre_sorted; : scoped_refptr<Counter> bulk_check_batches_needed_sort; > We could use these metrics for workload characterization in terms of orderi I see. I'm not sure that's something interesting/important to know for any workload, but if you think it may be valuable in some cases, perhaps we can keep it. For more context why I'm hesitant about adding these: the problem with per-tablet metrics is their huge multiplication factor. In large deployments there are often 100K+ tablets, and it adds up. It's a penalty to harvest, store, and aggregate (in Prometheus, etc.) metrics that aren't quite relevant for monitoring and troubleshooting (or create and maintain filters that remove them during metrics scraping). -- To view, visit http://gerrit.cloudera.org:8080/24615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28d3f5ebdf7e3f13f04ffe8d35417a98c370fcf7 Gerrit-Change-Number: 24615 Gerrit-PatchSet: 4 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Wed, 02 Sep 2026 17:11:23 +0000 Gerrit-HasComments: Yes
