Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24615 )
Change subject: [tablet] Skip stable_sort for already sorted batch ...................................................................... Patch Set 4: Verified+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/24615/3/src/kudu/tablet/tablet_metrics.h File src/kudu/tablet/tablet_metrics.h: http://gerrit.cloudera.org:8080/#/c/24615/3/src/kudu/tablet/tablet_metrics.h@78 PS3, Line 78: // Fast-path / slow-path split for the sort-skip optimisation in : // Tablet::BulkCheckPresence. : scoped_refptr<Counter> bulk_check_batches_pre_sorted; : scoped_refptr<Counter> bulk_check_batches_needed_sort; > I see. I'm not sure that's something interesting/important to know for any I agree these could drive memory usage by a couple MBs with every 1K tablet and some additional disk space and scrape time. That is not significant considering it is around 3% increase to tablet metrics category. I would still go ahead with the change as is. -- To view, visit http://gerrit.cloudera.org:8080/24615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28d3f5ebdf7e3f13f04ffe8d35417a98c370fcf7 Gerrit-Change-Number: 24615 Gerrit-PatchSet: 4 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Thu, 03 Sep 2026 09:24:27 +0000 Gerrit-HasComments: Yes
