David Ribeiro Alves has submitted this change and it was merged.
Change subject: Do not run (g)addr2line translator on MacOS X
......................................................................
Do not run (g)addr2line translator on MacOS X
When running tests on MacOS X, omit using the
stacktrace_addr2line.pl utility to translate addresses to line numbers.
For current builds on MacOS X, neither (g)addr2line nor atos
translate stack address into line number without extra-hassle.
This is so even for binaries linked without PIE
(see the -no_pie linker's option).
As for the extra-hassle part: there are at least two ways
to address that, but neither looks like a good candidate
in the context of the script.
Option A:
Provide the atos utility with reference to running test process
using '-p <pid>' option. This, however, triggers a pop-up
requesting for password if it's run the very first time.
Option B:
Take a snapshot of running test process using MacOS X tools
and provide the atos utility with the load address
using '-l <addr>' option.
Change-Id: Idf8a81ae7f2e1b938734a4b66bec82cb731d90cc
Reviewed-on: http://gerrit.cloudera.org:8080/3360
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves <dral...@apache.org>
---
M build-support/run-test.sh
1 file changed, 13 insertions(+), 1 deletion(-)
Approvals:
David Ribeiro Alves: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf8a81ae7f2e1b938734a4b66bec82cb731d90cc
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
