Jean-Daniel Cryans has posted comments on this change. Change subject: Update Java client for new master GetTableLocations semantics ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/3303/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java: Line 1134: if (response.getError().getCode() == Master.MasterErrorPB.Code.TABLET_NOT_RUNNING) { IIUC you're relying on existing tests to pass to verify this new check? http://gerrit.cloudera.org:8080/#/c/3303/2/java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduClient.java File java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduClient.java: Line 203: new byte[] { (byte) 0x80, 0x00, 0x00, 0x32 }, Got some long lines here and below. Line 249: assertTrue("unreachable", false); use fail() -- To view, visit http://gerrit.cloudera.org:8080/3303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80bf5661aed1ba435800211411b3273874e5bbcf Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
