Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] use tablet cache for locateTablet calls ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3386/1/docs/release_notes.adoc File docs/release_notes.adoc: PS1, Line 63: Applications are : encouraged to use the scan tokens API instead of these methods in the future. Seems like you could also add that in KuduTable's javadoc for the methods above. http://gerrit.cloudera.org:8080/#/c/3386/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java: Line 1128: // If the partition key location isn't cached, then kick off a new tablet Odd comment placement. Line 1927: synchronized (replicas) { Pretty sure this needs to be under the synchronized block above, else concurrent metadata refreshes might leave you in a weird state. -- To view, visit http://gerrit.cloudera.org:8080/3386 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78b5d400778547a9ee090111663677901dbadd98 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
