David Ribeiro Alves has posted comments on this change.

Change subject: Allow to set RequestId in the RPC RequestHeader
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3179/3/src/kudu/rpc/rpc_controller.h
File src/kudu/rpc/rpc_controller.h:

Line 110:   void SetRequestIdPB(std::unique_ptr<RequestIdPB> request_id);
> per some comments on an earlier (committed) patch in this series, I think w
are you referring to https://gerrit.cloudera.org/#/c/3079/ ? I did address your 
comment and add more info in rpc_header.proto.

I quite like the "request" terminology, think it makes sense even when sending 
something to different replicas.  Unless you have a better naming suggestion 
I'll add (even) more info to rpc_header.proto to make the distinction clear. 
Will push a patch just for that so that we can discuss it there.


-- 
To view, visit http://gerrit.cloudera.org:8080/3179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92566250683ee69fad57a9ae694842d4a0b17ab4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to