Mike Percy has posted comments on this change. Change subject: consensus: Crash if we fail to append to the WAL ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3406/3/src/kudu/util/status_callback.cc File src/kudu/util/status_callback.cc: Line 19: > Nit: why the reorder? Doesn't "status" precede "status_callback"? status_callback.h is the header file for this .cc file. It comes first. See https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes -- To view, visit http://gerrit.cloudera.org:8080/3406 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c5ffa6d60f46ce4d6c3da4c6e7878ab07d99c65 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes