Dan Burkert has posted comments on this change. Change subject: locks: add new read-write mutex ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3496/2/src/kudu/util/rw_mutex.cc File src/kudu/util/rw_mutex.cc: Line 43: int rv = pthread_rwlock_rdlock(&native_handle_); reading the manpage, it seems to me some of the errors could possibly occur in the wild: [EDEADLK] The current thread already owns the read-write lock for writing. [EAGAIN] The read lock could not be acquired because the maximum number of read locks for rwlock has been exceeded. Although maybe we are betting on these cases being weeded out in testing? -- To view, visit http://gerrit.cloudera.org:8080/3496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5462e69291fb9498ebd4aaa1728c64658667aa4b Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
