Adar Dembo has posted comments on this change. Change subject: locks: add new read-write mutex ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/3496/2/src/kudu/util/rw_mutex.cc File src/kudu/util/rw_mutex.cc: Line 26: DCHECK_EQ(0, rv) << strerror(rv); > does this cause "unused" warnings in release builds? perhaps need to use at Yes it does. As do the unused 'rv' in Mutex and ConditionVariable. I'll fix up all of them. Line 39: DCHECK_EQ(0, rv) << strerror(rv); > same here and below Done Line 43: int rv = pthread_rwlock_rdlock(&native_handle_); > reading the manpage, it seems to me some of the errors could possibly occur Yes, I think we generally expect these to be caught in testing. I was following the Mutex and ConditionVariable implementations. -- To view, visit http://gerrit.cloudera.org:8080/3496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5462e69291fb9498ebd4aaa1728c64658667aa4b Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
