Todd Lipcon has posted comments on this change. Change subject: Implement kudu::optional replacement for boost::optional ......................................................................
Patch Set 1: The boost implementation already has ASSERTs for accessing it while not initialized, so the additional value of the asan stuff is not huge IMO. Also not sure of the purpose of the extra red zones (ASAN would already insert those around the object, right?) Anyway I'm not going to block this if everyone else thinks this is a good idea, it just seems like complicated stuff to get right, and I'd rather trust boost:: or std:: (in some future c++17 world) to do it for us. -- To view, visit http://gerrit.cloudera.org:8080/3512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib80c35cc9a4712572f85eeb7717e17869cd5e081 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: No
