Adar Dembo has posted comments on this change. Change subject: locks: add new read-write mutex ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3496/5/src/kudu/util/mutex.cc File src/kudu/util/mutex.cc: Line 87: DCHECK_EQ(0, rv) << ". " << strerror(rv) > Ok fair enough. Final comment: could this be folded back into the original If I move it into the #ifdef, the unused variable warning for 'rv' will resurface. -- To view, visit http://gerrit.cloudera.org:8080/3496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5462e69291fb9498ebd4aaa1728c64658667aa4b Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
