Todd Lipcon has posted comments on this change. Change subject: KUDU-763 consensus queue metrics on followers are messed up ......................................................................
Patch Set 2: (2 comments) Should have a test as well for this http://gerrit.cloudera.org:8080/#/c/3501/2/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: Line 77: "not all peers. Not meaningful for non-leader tablet replicas."); I do think we should actually make the data at least be "0" in the case that it's a follower. Right now, the numbers go negative which is pretty odd. Remember that the metrics aren't just exposed on that web UI, but also in other systems which capture metrics. http://gerrit.cloudera.org:8080/#/c/3501/2/src/kudu/tserver/tserver-path-handlers.cc File src/kudu/tserver/tserver-path-handlers.cc: Line 251: peer.has_last_known_addr() ? Substitute("$0:$1", would be good to move these web ui improvements to a separate patch -- To view, visit http://gerrit.cloudera.org:8080/3501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fb0d45f85786b9e2631b5dc0bf044a9d3192a39 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
