Todd Lipcon has posted comments on this change. Change subject: KUDU-1358 (part 3): new multi-master stress test ......................................................................
Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/3611/9/src/kudu/integration-tests/master-stress-test.cc File src/kudu/integration-tests/master-stress-test.cc: PS9, Line 73: tT admin? Line 219: // TODO: Should be fixed with Exactly Once semantics. would be nice to tie these to JIRAs Line 223: num_altered++; why not get rid of these local variables and just IncrementBy(1) on the global atomic? Line 323: SleepFor(MonoDelta::FromMilliseconds(100)); would be good to randomize the sleeps, so you might catch some slightly different interleavings -- To view, visit http://gerrit.cloudera.org:8080/3611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40b5b78c100a7b427b2f4aac3a54665e82a9618c Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
