Dan Burkert has posted comments on this change. Change subject: KUDU-1358 (part 3): new multi-master stress test ......................................................................
Patch Set 10: (6 comments) http://gerrit.cloudera.org:8080/#/c/3611/2/src/kudu/integration-tests/master-stress-test.cc File src/kudu/integration-tests/master-stress-test.cc: Line 87: virtual void SetUp() OVERRIDE { signature should look like void SetUp() override { here and below http://gerrit.cloudera.org:8080/#/c/3611/10/src/kudu/integration-tests/master-stress-test.cc File src/kudu/integration-tests/master-stress-test.cc: Line 87: virtual void SetUp() OVERRIDE { void SetUp() override { here and below Line 174: if (s.IsServiceUnavailable()) { This still seems really funky to me, but oh well. Line 212: // The client retried after the RPC timed out, but the master did in Seems to me this is unlikely to timeout, since it's not really doing much on the master side before returning. The NotFound returns are more likely due to another thread renaming or deleting the table. Line 238: // TODO: Should be fixed with Exactly Once semantics, see KUDU-1537. same here Line 294: ExternalMaster* master = cluster_->master( maybe a rolling restart would be more effective at shuffling around the master? i.e. keep a counter and pick the master by (++counter % master_count) -- To view, visit http://gerrit.cloudera.org:8080/3611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40b5b78c100a7b427b2f4aac3a54665e82a9618c Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
