> On April 22, 2015, 12:38 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, lines 2458-2459 > > <https://reviews.apache.org/r/32150/diff/5/?file=920953#file920953line2458> > > > > These two fields are optional, `principal` doesn't have a default. Do > > we need to check it? Can a framework without a principal reserve resources > > (the answer is no, I suppose, because in the current desgin a principal > > register resources, not a framework)? > > > > DO you mind adding tests for these cases?
Thanks for this! Fixed and added a test `FrameworkMissingPrincipal`. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32150/#review81139 ----------------------------------------------------------- On April 28, 2015, 10:21 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32150/ > ----------------------------------------------------------- > > (Updated April 28, 2015, 10:21 p.m.) > > > Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu. > > > Bugs: MESOS-2139 > https://issues.apache.org/jira/browse/MESOS-2139 > > > Repository: mesos > > > Description > ------- > > Handled reservation operations in `Master::_accept`. > > Added `validate` functions in `src/master/validation.{hpp,cpp}`. > > > Diffs > ----- > > src/master/master.cpp d42a6f321c88ec5d0418264bdda39d083ff54a7e > src/master/validation.hpp 2d7416c053f82d6316542fa9c35b0e7bc605abec > src/master/validation.cpp dc25995bf57397d42fcde458414f0402d19bf792 > src/tests/master_validation_tests.cpp > 4f2ad58c3ae0f611fb476c4d91a37dd6a5541395 > > Diff: https://reviews.apache.org/r/32150/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
