> On April 8, 2015, 10:38 p.m., Jie Yu wrote: > > src/master/validation.cpp, lines 581-584 > > <https://reviews.apache.org/r/32150/diff/5/?file=920955#file920955line581> > > > > Is this necessary, or will be captured by the resources contains check > > later?
It probably would be checked by `contains`, since there shouldn't be any unreserved resources with `disk` set. Having said that, I think it's worthwhile keeping this check since this error message will be more useful to the user than the error message that `contains` would produce. > On April 8, 2015, 10:38 p.m., Jie Yu wrote: > > src/tests/master_validation_tests.cpp, lines 178-189 > > <https://reviews.apache.org/r/32150/diff/5/?file=920956#file920956line178> > > > > Can you split this test into a few smaller tests (i.e., one for each {} > > block)? The comment in each {} block can be the test name. In that way, > > when a test fails, you immediately know what went wrong. What do you think? Yeah, I agree! I'll split it in other places. In this case, the 2 tests had no functional difference so I just removed one of them. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32150/#review79442 ----------------------------------------------------------- On April 27, 2015, 10:10 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32150/ > ----------------------------------------------------------- > > (Updated April 27, 2015, 10:10 p.m.) > > > Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu. > > > Bugs: MESOS-2139 > https://issues.apache.org/jira/browse/MESOS-2139 > > > Repository: mesos > > > Description > ------- > > Handled reservation operations in `Master::_accept`. > > Added `validate` functions in `src/master/validation.{hpp,cpp}`. > > > Diffs > ----- > > src/master/master.cpp d42a6f321c88ec5d0418264bdda39d083ff54a7e > src/master/validation.hpp 2d7416c053f82d6316542fa9c35b0e7bc605abec > src/master/validation.cpp dc25995bf57397d42fcde458414f0402d19bf792 > src/tests/master_validation_tests.cpp > 4f2ad58c3ae0f611fb476c4d91a37dd6a5541395 > > Diff: https://reviews.apache.org/r/32150/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
