----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33823/#review82545 -----------------------------------------------------------
Can you add comments to the protobufs as we did for scheduler proto? include/mesos/executor/executor.proto <https://reviews.apache.org/r/33823/#comment133293> s/RUN/LAUNCH/ include/mesos/executor/executor.proto <https://reviews.apache.org/r/33823/#comment133288> Is FrameworkID not present in FrameworkInfo? include/mesos/executor/executor.proto <https://reviews.apache.org/r/33823/#comment133289> Ditto. SlaveID should already be in SlaveInfo? include/mesos/executor/executor.proto <https://reviews.apache.org/r/33823/#comment133290> Why FrameworkInfo? include/mesos/executor/executor.proto <https://reviews.apache.org/r/33823/#comment133291> Why SlaveID and FrameworkID? include/mesos/executor/executor.proto <https://reviews.apache.org/r/33823/#comment133314> Ditto. Kill these. include/mesos/executor/executor.proto <https://reviews.apache.org/r/33823/#comment133315> Kill these? include/mesos/executor/executor.proto <https://reviews.apache.org/r/33823/#comment133317> s/StatusUpdate/Update/ include/mesos/executor/executor.proto <https://reviews.apache.org/r/33823/#comment133318> No corresponding Type for this? Also, how and when is this used? - Vinod Kone On May 4, 2015, 10:21 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33823/ > ----------------------------------------------------------- > > (Updated May 4, 2015, 10:21 p.m.) > > > Review request for mesos, Isabel Jimenez, Marco Massenzio, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/executor/executor.hpp PRE-CREATION > include/mesos/executor/executor.proto PRE-CREATION > src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b > > Diff: https://reviews.apache.org/r/33823/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
