> On May 9, 2015, 4:27 a.m., Marco Massenzio wrote:
> > include/mesos/executor/executor.hpp, line 22
> > <https://reviews.apache.org/r/33823/diff/1/?file=949197#file949197line22>
> >
> >     please avoid SCREAMING COMMENTS :)
> >     (also, not sure what is the use of that comment? is it a TODO? should 
> > we have a #pragma? what?)

1. It is a warning.
2. The purpose of this header is to be a reflection of 
`include/mesos/scheduler/scheduler.hpp`, and so they both have the same 
comments, in fact they look mostly identical which follows the maxim of being 
consistent.


> On May 9, 2015, 4:27 a.m., Marco Massenzio wrote:
> > include/mesos/executor/executor.proto, line 80
> > <https://reviews.apache.org/r/33823/diff/1/?file=949198#file949198line80>
> >
> >     `message` is becoming a truly overloaded term here: as a Protobuf 
> > message, the Message class, this (string) variable here, the (Message) 
> > `message` field below... how about `errorMessage` instead?

It is called like that, because it is forwarded from the master and to the 
master. While I agree with you in principle, you know we like consistency. Why 
not discuss it in the HTTP API meeting?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33823/#review83125
-----------------------------------------------------------


On May 5, 2015, 12:21 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33823/
> -----------------------------------------------------------
> 
> (Updated May 5, 2015, 12:21 a.m.)
> 
> 
> Review request for mesos, Isabel Jimenez, Marco Massenzio, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/executor/executor.hpp PRE-CREATION 
>   include/mesos/executor/executor.proto PRE-CREATION 
>   src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b 
> 
> Diff: https://reviews.apache.org/r/33823/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to