> On May 5, 2015, 10:42 p.m., Vinod Kone wrote:
> > include/mesos/executor/executor.proto, line 48
> > <https://reviews.apache.org/r/33823/diff/1/?file=949198#file949198line48>
> >
> >     Is FrameworkID not present in FrameworkInfo?

It is but it is optional. Should we instead expect it to be there and fail if 
not?


> On May 5, 2015, 10:42 p.m., Vinod Kone wrote:
> > include/mesos/executor/executor.proto, line 50
> > <https://reviews.apache.org/r/33823/diff/1/?file=949198#file949198line50>
> >
> >     Ditto. SlaveID should already be in SlaveInfo?

Same as above. Both are supposedly available after registration, so technically 
not needed here.


> On May 5, 2015, 10:42 p.m., Vinod Kone wrote:
> > include/mesos/executor/executor.proto, lines 60-61
> > <https://reviews.apache.org/r/33823/diff/1/?file=949198#file949198line60>
> >
> >     Why SlaveID and FrameworkID?

They are required by `ExecutorProcess::statusUpdateAcknowledgement`; though 
only FrameworkId is used and only to log.


> On May 5, 2015, 10:42 p.m., Vinod Kone wrote:
> > include/mesos/executor/executor.proto, line 117
> > <https://reviews.apache.org/r/33823/diff/1/?file=949198#file949198line117>
> >
> >     No corresponding Type for this?
> >     
> >     Also, how and when is this used?

I had problems with the naming and I can use your help. The core issue here is, 
the message is use for resubscription. It just adds the list of unacknowledged 
messages and that is the difference with the subscription message which is 
mostly empty, any idea for a name?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33823/#review82545
-----------------------------------------------------------


On May 5, 2015, 12:21 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33823/
> -----------------------------------------------------------
> 
> (Updated May 5, 2015, 12:21 a.m.)
> 
> 
> Review request for mesos, Isabel Jimenez, Marco Massenzio, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/executor/executor.hpp PRE-CREATION 
>   include/mesos/executor/executor.proto PRE-CREATION 
>   src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b 
> 
> Diff: https://reviews.apache.org/r/33823/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to