-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30643/#review82830
-----------------------------------------------------------


Are you still planning to merge this?

- Timothy Chen


On Feb. 4, 2015, 11:48 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30643/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 11:48 p.m.)
> 
> 
> Review request for mesos, Timothy Chen and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Provided executor will be used to run the task rather than deferring to the 
> slave to determine an executor to use (currently the local included command 
> executor).
> 
> This is helpful for testing containers with filesystem isolation as you can 
> fetch an executor into the work directory rather than using the command 
> executor on the host filesystem. You can, of course, still use the command 
> executor, but it will be copied/fetched.
> 
> +tnachen - can you please verify I've preserved the override functionality in 
> the command executor? Is that still required?
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp 77deec91177c90a8a20ccd4fe063b82ca08cefbd 
>   src/common/parse.hpp ae581e5168606bf7ea7e092c5095ddf9d321c792 
>   src/launcher/executor.cpp 1cf28f168cac6e8c7e98686a35509c2b4e052504 
> 
> Diff: https://reviews.apache.org/r/30643/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> manually used 'mesos execute' and specified command executor, both directly 
> as the value and fetching from file:///. Tested enviroment variables too.
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Reply via email to