----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33963/#review83022 -----------------------------------------------------------
src/linux/routing/filter/arp.cpp <https://reviews.apache.org/r/33963/#comment133891> Can you remove arp.hpp and arp.cpp completely and use the basic filter you just created? src/linux/routing/filter/basic.hpp <https://reviews.apache.org/r/33963/#comment133892> I would rather not introduce this special version as it's semantics is rather implicit (one needs to read the document to figure out that it's for ETH_P_ALL). Simply use exists(link, parent, ETH_P_ALL) at callsites. src/linux/routing/filter/basic.hpp <https://reviews.apache.org/r/33963/#comment133893> Ditto. No need for this. src/linux/routing/filter/basic.hpp <https://reviews.apache.org/r/33963/#comment133895> Ditto. No need for this interface. - Jie Yu On May 8, 2015, 12:14 a.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33963/ > ----------------------------------------------------------- > > (Updated May 8, 2015, 12:14 a.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2422 > https://issues.apache.org/jira/browse/MESOS-2422 > > > Repository: mesos > > > Description > ------- > > After adding basic filter, ARP filter implementation now can move onto basic > filter, this also matches kernel implementation too. > > > Diffs > ----- > > src/linux/routing/filter/arp.cpp 8c4976620ec296b44cefec375b5f21986cc886ae > src/linux/routing/filter/basic.hpp PRE-CREATION > src/linux/routing/filter/basic.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/33963/diff/ > > > Testing > ------- > > Run ARP filter test cases > > > Thanks, > > Cong Wang > >
