----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33963/#review83063 -----------------------------------------------------------
Patch looks great! Reviews applied: [31502, 31503, 31504, 33963] All tests passed. - Mesos ReviewBot On May 8, 2015, 7:29 p.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33963/ > ----------------------------------------------------------- > > (Updated May 8, 2015, 7:29 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2422 > https://issues.apache.org/jira/browse/MESOS-2422 > > > Repository: mesos > > > Description > ------- > > After adding basic filter, ARP filter implementation now can move onto basic > filter, this also matches kernel implementation. > > > Diffs > ----- > > src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b > src/linux/routing/filter/arp.hpp 819e8147b14193a50ce7f938676e86dbfd622ba0 > src/linux/routing/filter/arp.cpp 8c4976620ec296b44cefec375b5f21986cc886ae > src/linux/routing/filter/basic.hpp PRE-CREATION > src/linux/routing/filter/basic.cpp PRE-CREATION > src/slave/containerizer/isolators/network/port_mapping.cpp > fc0fa4c2086f0be84ab7ddc04b85dec4a3b5b5dc > src/tests/routing_tests.cpp ce583b59bf9fb2ef855aa82ab6083ea11b138e55 > > Diff: https://reviews.apache.org/r/33963/diff/ > > > Testing > ------- > > Run ARP filter test cases > > > Thanks, > > Cong Wang > >
