> On May 8, 2015, 5:37 p.m., Jie Yu wrote:
> > src/linux/routing/filter/arp.cpp, line 64
> > <https://reviews.apache.org/r/33963/diff/1/?file=952710#file952710line64>
> >
> > Can you remove arp.hpp and arp.cpp completely and use the basic filter
> > you just created?
Good point! We can move it into basic.{c,h}pp by keeping its namespace.
- Cong
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33963/#review83022
-----------------------------------------------------------
On May 8, 2015, 12:14 a.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33963/
> -----------------------------------------------------------
>
> (Updated May 8, 2015, 12:14 a.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu.
>
>
> Bugs: MESOS-2422
> https://issues.apache.org/jira/browse/MESOS-2422
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After adding basic filter, ARP filter implementation now can move onto basic
> filter, this also matches kernel implementation too.
>
>
> Diffs
> -----
>
> src/linux/routing/filter/arp.cpp 8c4976620ec296b44cefec375b5f21986cc886ae
> src/linux/routing/filter/basic.hpp PRE-CREATION
> src/linux/routing/filter/basic.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33963/diff/
>
>
> Testing
> -------
>
> Run ARP filter test cases
>
>
> Thanks,
>
> Cong Wang
>
>
