-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34141/#review84237
-----------------------------------------------------------



src/slave/containerizer/provisioners/appc/backend.hpp
<https://reviews.apache.org/r/34141/#comment135398>

    Not a big deal, but would it be more flexible for Bankend to take a 
rootImage as an argument instead of a vector, which is already flattened?
    
    Resolving an dependency tree could yield a list of all tree nodes for the 
copy backend.



src/slave/containerizer/provisioners/appc/backend.cpp
<https://reviews.apache.org/r/34141/#comment135399>

    put a nothing into the list before the for loop?


- Chi Zhang


On May 13, 2015, 12:48 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34141/
> -----------------------------------------------------------
> 
> (Updated May 13, 2015, 12:48 a.m.)
> 
> 
> Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Simple copy backend that forms the rootfs by copying each layer.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 14bc976a7b6a656fb58085484d25c3de3cf0f693 
>   src/slave/containerizer/provisioners/appc/backend.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/appc/backend.cpp PRE-CREATION 
>   src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032 
>   src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932 
> 
> Diff: https://reviews.apache.org/r/34141/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Reply via email to