----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34310/#review84371 -----------------------------------------------------------
My high leve comment: Lets add the following check/invariant in the master: "An executor and all its tasks should all use regular resources or should all use revocable resources". We can relax this policy in the future when we have better QoS mechanisms in place. Does that make sense? src/slave/containerizer/isolators/cgroups/cpushare.hpp <https://reviews.apache.org/r/34310/#comment135584> Optional? because this only gets set/updated in update(). - Vinod Kone On May 18, 2015, 8:49 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34310/ > ----------------------------------------------------------- > > (Updated May 18, 2015, 8:49 p.m.) > > > Review request for mesos, Joris Van Remoortere, Niklas Nielsen, and Vinod > Kone. > > > Bugs: MESOS-2652 > https://issues.apache.org/jira/browse/MESOS-2652 > > > Repository: mesos > > > Description > ------- > > Use IDLE scheduling for revocable CPU in cgroups isolator. > > > Diffs > ----- > > src/slave/containerizer/isolators/cgroups/cpushare.hpp > ff4a9dbdb1b655e71bf87dcee8fe62433d396f52 > src/slave/containerizer/isolators/cgroups/cpushare.cpp > 6a5b2b5c6e2844fe1a10815956569194b6f56681 > > Diff: https://reviews.apache.org/r/34310/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
