-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/#review84380
-----------------------------------------------------------



src/cli/mesos.cpp
<https://reviews.apache.org/r/34260/#comment135600>

    So basename can never return an error? When did ::basename() return NULL?


- Vinod Kone


On May 17, 2015, 10:42 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34260/
> -----------------------------------------------------------
> 
> (Updated May 17, 2015, 10:42 p.m.)
> 
> 
> Review request for mesos and Cody Maloney.
> 
> 
> Bugs: MESOS-1303
>     https://issues.apache.org/jira/browse/MESOS-1303
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp dbd19e6 
>   src/cli/mesos.cpp 171a707 
>   src/cli/resolve.cpp a99b609 
>   src/examples/load_generator_framework.cpp be1a3bf 
>   src/examples/low_level_scheduler_libprocess.cpp bee2e7e 
>   src/examples/low_level_scheduler_pthread.cpp fb8cd66 
>   src/examples/persistent_volume_framework.cpp 8a893fc 
>   src/examples/test_framework.cpp 9f4b53e 
>   src/files/files.cpp ce02411 
>   src/health-check/main.cpp a4ce742 
>   src/launcher/executor.cpp de6f1b1 
>   src/launcher/fetcher.cpp 796526f 
>   src/linux/cgroups.cpp df3211a 
>   src/local/main.cpp a641b9e 
>   src/logging/logging.cpp 6b14575 
>   src/master/main.cpp d5666bc 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 6a5b2b5 
>   src/slave/containerizer/isolators/cgroups/mem.cpp 2c218b2 
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 37967b5 
>   src/slave/containerizer/isolators/network/port_mapping.cpp a4abaff 
>   src/slave/containerizer/linux_launcher.cpp b9e22e3 
>   src/slave/main.cpp f762f5b 
>   src/slave/state.hpp fed4b7e 
>   src/slave/state.cpp 8eda22a 
>   src/slave/status_update_manager.hpp b4d91b2 
>   src/tests/fetcher_tests.cpp 4549e6a 
>   src/tests/main.cpp e3fff5d 
>   src/tests/mesos.cpp 1d5639c 
>   src/usage/main.cpp 97f55e9 
>   src/zookeeper/group.cpp 173caa8 
> 
> Diff: https://reviews.apache.org/r/34260/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Reply via email to