> On May 19, 2015, 8:13 p.m., Vinod Kone wrote:
> > src/cli/mesos.cpp, line 31
> > <https://reviews.apache.org/r/34260/diff/6/?file=962331#file962331line31>
> >
> >     So basename can never return an error? When did ::basename() return 
> > NULL?
> 
> Alexander Rojas wrote:
>     I checked in the `::basename` docs (`man 3 basename`) and the linux 
> version doesn't seem to return any error ever and the osx version returns 
> `NULL` and sets `errno = ENAMETOOLONG` if the length of the parameter is 
> larger than `MAXPATHLEN`.
> 
> Till Toenshoff wrote:
>     Thanks Alexander for jumping in - and yes indeed, the Posix as well as 
> the GNU version never seem to return NULL on linux (see 
> http://linux.die.net/man/3/basename). Can we drop this?

SGTM.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34260/#review84380
-----------------------------------------------------------


On June 5, 2015, 1:26 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34260/
> -----------------------------------------------------------
> 
> (Updated June 5, 2015, 1:26 p.m.)
> 
> 
> Review request for mesos and Cody Maloney.
> 
> 
> Bugs: MESOS-1303
>     https://issues.apache.org/jira/browse/MESOS-1303
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/cli/mesos.cpp 1121e19 
>   src/cli/resolve.cpp 74545a0 
>   src/examples/low_level_scheduler_libprocess.cpp df92e8d 
>   src/examples/low_level_scheduler_pthread.cpp 175ee4d 
>   src/examples/persistent_volume_framework.cpp ee2311f 
>   src/examples/test_framework.cpp 25f5f8c 
>   src/files/files.cpp ce02411 
>   src/health-check/main.cpp 3607479 
>   src/launcher/executor.cpp f79dc60 
>   src/linux/cgroups.cpp 831237b 
>   src/local/main.cpp ec21ed0 
>   src/logging/logging.cpp 6b14575 
>   src/slave/containerizer/fetcher.cpp f77652b 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 5bd3525 
>   src/slave/containerizer/isolators/cgroups/mem.cpp 9647e79 
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 3e5153f 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 871e9cf 
>   src/slave/containerizer/linux_launcher.cpp 8eae258 
>   src/slave/main.cpp c4d8940 
>   src/slave/state.hpp fed4b7e 
>   src/slave/state.cpp 8eda22a 
>   src/slave/status_update_manager.cpp 1d7c4d0 
>   src/tests/fetcher_tests.cpp 361d918 
>   src/tests/mesos.cpp d3a8bb7 
>   src/zookeeper/group.cpp 173caa8 
> 
> Diff: https://reviews.apache.org/r/34260/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Reply via email to